-
Notifications
You must be signed in to change notification settings - Fork 385
Specifying that you need Helm v2.5.0 for installation #1170
Conversation
This is a follow-up to kubernetes-retired#1163 (comment) sion_r135920291 Cc/ @MHBauer
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@arschles Thanks for following up! |
docs/install-1.6.md
Outdated
below. | ||
|
||
If you already have Helm v2 or newer, execute `helm init` (if you haven't | ||
If you already have Helm v2.5.0 or newer, execute `helm init` (if you haven't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating the version 3 times in a single section looks a bit redundant to me, I would leave if only for the first mention and omit the version completely in all other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nilebox I've removed redundancy
docs/install-1.6.md
Outdated
already) to install Tiller (the server-side component of Helm), and you should | ||
be done with Helm setup. | ||
|
||
If you don't already have Helm v2, see the | ||
If you don't already have Helm v2.5.0, see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"or newer" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@nilebox I've addressed your comments. If the changes are acceptable, can you merge (pending CI)? |
This is a follow-up to #1163 (comment)
Cc/ @MHBauer